Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcs] Make core worker test compilable. #23608

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

It seems like core worker test is not running and it breaks the build. This PR fixed this.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
Copy link
Contributor Author

Should we just delete this test since it's not enabled actually. @scv119
Also it's broken even after I make it compile

[2022-03-30 20:47:45,124 C 76 76] (raylet) local_resource_manager.cc:306:  Check failed: (_left_ == _right_)  0 vs 1
*** StackTrace Information ***
    ray::SpdLogMessage::Flush()
    ray::RayLog::~RayLog()
    ray::LocalResourceManager::UpdateAvailableObjectStoreMemResource()
    ray::LocalResourceManager::FillResourceUsage()
    ray::raylet::NodeManager::FillResourceReport()
    ray::raylet::NodeManager::HandleRequestResourceReport()
    std::_Function_handler<>::_M_invoke()
    EventTracker::RecordExecution()
    std::_Function_handler<>::_M_invoke()
    boost::asio::detail::completion_handler<>::do_complete()
    boost::asio::detail::scheduler::do_run_one()
    boost::asio::detail::scheduler::run()
    boost::asio::io_context::run()
    main
    __libc_start_main

@fishbone
Copy link
Contributor Author

windows wheel is built successfully. Mac is hanging forever. Failure is not related. Merge the PR.

@fishbone fishbone merged commit d01f947 into ray-project:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants