Add support for Clojure tools.build projects
#771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndneighbor
approved these changes
Jan 25, 2023
|
Will defer to @coffee-cup on what Nixpacks version this will go in. Also, it appears that CI needs to be appeased. |
|
@ndneighbor: Thanks for the quick review! I think I fixed the CI failures now. |
ndneighbor
approved these changes
Jan 25, 2023
coffee-cup
approved these changes
Jan 25, 2023
Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
|
Is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tools.buildlibrary is the official library for building Clojure projects from adeps.ednfile. This PR uses thebuild.cljfile for detection since technically other libraries besidestools.buildcould be built on top ofdeps.ednin the future.Resolves #372.