Improve css compiler #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brenogazzola just confirmed locally - it's working spectacularly, thank you! |
brenogazzola
force-pushed
the
improve-css-asset
branch
from
7adccc2
to
9496ea0
Compare
I don't have any issues with this branch as far as I know. You can merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on #50
Closes #78
Instead of stripping everything after the file extension, let's preserve it.
Also, make the regex less greedy.
@flipsasser could you confirm if this works for both your bugs?
@kevynlebouille or @HLFH would you mind checking if your uses cases are still working correctly?