Skip to content

Commit

Permalink
[vm/fuzzer] add --enable-asserts to AOT step
Browse files Browse the repository at this point in the history
Rationale:
This exposes certain bugs in a cleaner way
than just crashing. See bug for an example.

dart-lang#38965
dart-lang#38979

Change-Id: Ib6ce52e31d5ca539fb4aedab989638949751627f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122168
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
  • Loading branch information
aartbik authored and commit-bot@chromium.org committed Oct 21, 2019
1 parent 199a42f commit f77d719
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions runtime/tools/dartfuzz/dartfuzz_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ class TestRunnerAOT implements TestRunner {
snapshot = '$tmp/snapshot';
env = Map<String, String>.from(e);
env['DART_CONFIGURATION'] = tag;
env['DART_VM_FLAGS'] = '--enable-asserts';
cmd = [precompiler, ...extraFlags, fileName, snapshot];
}

Expand All @@ -200,8 +201,11 @@ class TestRunnerAOT implements TestRunner {
}

void printReproductionCommand() {
print(
["DART_CONFIGURATION=${env['DART_CONFIGURATION']}", ...cmd].join(" "));
print([
"DART_CONFIGURATION='${env['DART_CONFIGURATION']}'",
"DART_VM_FLAGS='${env['DART_VM_FLAGS']}'",
...cmd
].join(" "));
print([dart, snapshot].join(" "));
}

Expand Down

0 comments on commit f77d719

Please sign in to comment.