Skip to content

Commit

Permalink
Remove unnecessary ignore comment
Browse files Browse the repository at this point in the history
Change-Id: I40bdf75ccfc0d22c93dfbb7bbea5c860198b065b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217022
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
  • Loading branch information
bwilkerson authored and commit-bot@chromium.org committed Oct 20, 2021
1 parent db45ae1 commit 1ac19c4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions pkg/dartdev/lib/src/analysis_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ class AnalysisServer {

_process = await startDartProcess(sdk, command);
// This callback hookup can't throw.
// ignore: unawaited_futures
_process.exitCode.whenComplete(() => _process = null);

final Stream<String> errorStream = _process.stderr
Expand All @@ -110,7 +109,6 @@ class AnalysisServer {

_streamController('server.error').stream.listen(_handleServerError);

// ignore: unawaited_futures
_sendCommand('server.setSubscriptions', params: <String, dynamic>{
'subscriptions': <String>['STATUS'],
});
Expand All @@ -136,7 +134,6 @@ class AnalysisServer {
}
});

// ignore: unawaited_futures
_sendCommand('analysis.setAnalysisRoots', params: <String, dynamic>{
'included': analysisRootPaths,
'excluded': <String>[]
Expand Down
1 change: 0 additions & 1 deletion pkg/dartdev/lib/src/commands/analyze.dart
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ class AnalyzeCommand extends DartdevCommand {

bool analysisFinished = false;

// ignore: unawaited_futures
server.onExit.then((int exitCode) {
if (!analysisFinished) {
io.exitCode = exitCode;
Expand Down
1 change: 0 additions & 1 deletion pkg/dartdev/lib/src/commands/fix.dart
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ To use the tool, run either ['dart fix --dry-run'] for a preview of the proposed
await server.start();

EditBulkFixesResult fixes;
//ignore: unawaited_futures
server.onExit.then((int exitCode) {
if (fixes == null && exitCode != 0) {
progress?.cancel();
Expand Down

0 comments on commit 1ac19c4

Please sign in to comment.