Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ellipsis dependency in favour of rlang #1875

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Remove ellipsis dependency in favour of rlang #1875

merged 3 commits into from
Nov 29, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Sep 29, 2023 •
edited
Loading

was further tweaked in 932989c and transformed to

  check_dots_used(error = function(cnd) {
    warn(conditionMessage(cnd), call = error_call)
  })

which led me to open r-lib/rlang#1675

krlmlr
krlmlr approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@hadley hadley merged commit 4b79ede into r-lib:main Nov 29, 2023
12 checks passed
@hadley
Copy link
Member

hadley commented Nov 29, 2023

Thank you!

@olivroy olivroy deleted the ellipsis branch November 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivroy @hadley @krlmlr