-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced logic around the ValidateFieldsOutOfOrder
setting
#481
Enhanced logic around the ValidateFieldsOutOfOrder
setting
#481
Conversation
Enhancements made to correctly parse Header fields found in the body of a message
Enhancements made to correctly parse Header fields found in the body of a message
Hi @chrjohn |
Hi @chrjohn This pull request is now ready for review. All checks have passed. Please let me know if you have any concerns with the changes I've made. Kind regards |
Hi @jacques0803 thanks for the PR and the extensive test. Would you mind creating a test for a FIX version below FIX5.0 (i.e. where there is no separate session dictionary)? |
Hi @chrjohn |
Hi @chrjohn Additional unit test case added for pre-FIXT11 and all checks have passed. Ready for your review again. Regards |
ValidateFieldsOutOfOrder
setting
Done. Sorry for missing it.
|
Thank you @chrjohn Would you mind merging the Pull Request as well, as I do not have write access on the repository. Regards |
Hi @jacques0803 , currently in the process of reviewing/merging/creating some PRs. Will merge yours in due course. |
Co-authored-by: Christoph John <christoph.john@macd.com>
Enhancements made to correctly parse Header fields found in the body of a message.
Fixes #468