Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced logic around the ValidateFieldsOutOfOrder setting #481

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Enhanced logic around the ValidateFieldsOutOfOrder setting #481

merged 5 commits into from
Dec 23, 2022

Conversation

jacques0803
Copy link
Contributor

@jacques0803 jacques0803 commented Apr 19, 2022

Enhancements made to correctly parse Header fields found in the body of a message.

Fixes #468

Enhancements made to correctly parse Header fields found in the body of a message
@jacques0803 jacques0803 marked this pull request as ready for review April 19, 2022 05:55
Enhancements made to correctly parse Header fields found in the body of a message
@jacques0803
Copy link
Contributor Author

Hi @chrjohn
Would you mind approving the running of the workflows. As a first-timer, I need a maintainer to initiate the CI workflows.
Regards

@jacques0803
Copy link
Contributor Author

Hi @chrjohn

This pull request is now ready for review. All checks have passed. Please let me know if you have any concerns with the changes I've made.

Kind regards

@chrjohn
Copy link
Member

chrjohn commented Apr 28, 2022

Hi @jacques0803 thanks for the PR and the extensive test. Would you mind creating a test for a FIX version below FIX5.0 (i.e. where there is no separate session dictionary)?
Thanks

@jacques0803
Copy link
Contributor Author

Hi @jacques0803 thanks for the PR and the extensive test. Would you mind creating a test for a FIX version below FIX5.0 (i.e. where there is no separate session dictionary)? Thanks

Hi @chrjohn
Done. Could you please approve the workflows again for me.
Regards
Jacques

@jacques0803
Copy link
Contributor Author

Hi @chrjohn

Additional unit test case added for pre-FIXT11 and all checks have passed. Ready for your review again.

Regards
Jacques

@jacques0803 jacques0803 changed the title ValidateFieldsOutOfOrder Enhanced logic around the ValidateFieldsOutOfOrder setting May 11, 2022
@jacques0803 jacques0803 changed the title Enhanced logic around the ValidateFieldsOutOfOrder setting Enhanced logic around the ValidateFieldsOutOfOrder setting May 11, 2022
@chrjohn
Copy link
Member

chrjohn commented Oct 11, 2022 via email

@jacques0803
Copy link
Contributor Author

Thank you @chrjohn

Would you mind merging the Pull Request as well, as I do not have write access on the repository.

Regards
Jacques

@chrjohn
Copy link
Member

chrjohn commented Oct 12, 2022

Hi @jacques0803 , currently in the process of reviewing/merging/creating some PRs. Will merge yours in due course.

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Dec 20, 2022
Co-authored-by: Christoph John <christoph.john@macd.com>
@chrjohn chrjohn merged commit fb074a6 into quickfix-j:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration parameter ValidateFieldsOutOfOrder not working when header fields found in body part
2 participants