Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add udev rule for the WB32 DFU bootloader #19135

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Add udev rule for the WB32 DFU bootloader #19135

merged 2 commits into from
Nov 27, 2022

Conversation

GabMus
Copy link
Contributor

@GabMus GabMus commented Nov 22, 2022

Description

Added a udev rule to give proper access to the Glorious GMMK 2 compact ANSI in bootloader mode on Linux.

Tested and it works correctly, it avoids having to manually chown the device file when flashing.

The vendor id and product id were extracted from lsusb with the keyboard in bootloader mode, here's the relevant output line:

Bus 005 Device 008: ID 342d:dfa0 Westberry Tech. WB Device in DFU Mode

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Tested and it works correctly, it avoids having to manually chown the device file when flashing.

The vendor id and product id were extracted from lsusb with the keyboard in bootloader mode, here's the relevant output line:

```
Bus 005 Device 008: ID 342d:dfa0 Westberry Tech. WB Device in DFU Mode
```
@github-actions github-actions bot added the core label Nov 22, 2022
util/udev/50-qmk.rules Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team November 22, 2022 05:39
Co-authored-by: Ryan <fauxpark@gmail.com>
@sigprof sigprof changed the title Add udev rule for GMMK2 p65 ANSI Add udev rule for the WB32 DFU bootloader Nov 27, 2022
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule should have been added together with the rest of WB32 support, but apparently had been missed.

@tzarc tzarc merged commit d915ab5 into qmk:develop Nov 27, 2022
@GabMus GabMus deleted the patch-1 branch November 28, 2022 07:51
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants