Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for get style definition #1574

Merged
merged 14 commits into from
Aug 24, 2023
Merged

Add support for get style definition #1574

merged 14 commits into from
Aug 24, 2023

Conversation

cnmlgbgithub
Copy link
Contributor

PR Details

Create a new GetStyle function to get style definitions

Description

Support to get the fills, theme color, font family, font size, alignment, cell protections, build-in, and custom number formats, implement this feature in the styles.go source code

Related Issue

#314, #1520 and #1521

Motivation and Context

How Has This Been Tested

All existing unit tests passed and new unit test cases passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cnmlgbgithub cnmlgbgithub marked this pull request as draft July 11, 2023 16:59
styles.go Outdated Show resolved Hide resolved
styles.go Outdated Show resolved Hide resolved
@cnmlgbgithub cnmlgbgithub requested a review from xuri July 25, 2023 16:27
styles.go Show resolved Hide resolved
@cnmlgbgithub cnmlgbgithub requested a review from xuri August 19, 2023 15:03
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to implement extractNumFmt, extractAlignment and extractProtection in this change list.

styles.go Outdated Show resolved Hide resolved
styles.go Outdated Show resolved Hide resolved
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I've left some comments.

styles_test.go Show resolved Hide resolved
styles.go Outdated Show resolved Hide resolved
styles.go Outdated Show resolved Hide resolved
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2023
@cnmlgbgithub cnmlgbgithub marked this pull request as ready for review August 24, 2023 15:15
@cnmlgbgithub cnmlgbgithub requested a review from xuri August 24, 2023 15:16
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit db22452 into qax-os:master Aug 24, 2023
33 checks passed
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
…x-os#1574)

- Add new function GetStyle support for get style definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
3 participants