Automatic Logger Level Update #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlazos
reviewed
Sep 13, 2022
jansel
reviewed
Sep 13, 2022
jansel
approved these changes
Sep 15, 2022
mlazos
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1184 by updating logger levels whenever
torchdynamo.config.log_levelis updated.Additional changes:
log_cli=Truein pytest.ini (Correct TorchDynamo pytest log output #1197) since it pollutes local tests (e.g.pytest test).Torchdynamo test: run a function multiple times and expect different log levels in outputs:
pytest -v -s test/test_misc.py::MiscTests::test_config_log_level.PyTorch test: Add
import torchdynamo; import logging; torchdynamo.config.log_level = logging.DEBUGto a test that purposefully fails (i.e. addself.assertTrue(False)to the testPYTORCH_TEST_WITH_DYNAMO=1 pytest test/test_optim.py -k test_new_pattern_no_warning)