Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile with cudart #737

Merged
merged 2 commits into from
Feb 14, 2017
Merged

compile with cudart #737

merged 2 commits into from
Feb 14, 2017

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Feb 13, 2017

This makes it work on osx with cuda and cudnn. Else it give:

...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/torch/__init__.py", line 45, in <module>
    from torch._C import *
ImportError: dlopen(/usr/local/lib/python2.7/site-packages/torch/_C.so, 10): Symbol not found: _cudaDeviceSynchronize
  Referenced from: /usr/local/lib/python2.7/site-packages/torch/_C.so
  Expected in: flat namespace
 in /usr/local/lib/python2.7/site-packages/torch/_C.so

This makes it work on osx with cuda and cudnn. Else it give:

```
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/torch/__init__.py", line 45, in <module>
    from torch._C import *
ImportError: dlopen(/usr/local/lib/python2.7/site-packages/torch/_C.so, 10): Symbol not found: _cudaDeviceSynchronize
  Referenced from: /usr/local/lib/python2.7/site-packages/torch/_C.so
  Expected in: flat namespace
 in /usr/local/lib/python2.7/site-packages/torch/_C.so
```
@apaszke
Copy link
Contributor

apaszke commented Feb 13, 2017

I think it should be conditioned on WITH_CUDA not on WITH_CUDNN.

@kashif
Copy link
Contributor Author

kashif commented Feb 13, 2017

yes just pushing that...

@kashif
Copy link
Contributor Author

kashif commented Feb 13, 2017

@apaszke done... off to bed! 😴

@soumith soumith merged commit 8d90ab2 into pytorch:master Feb 14, 2017
@soumith
Copy link
Member

soumith commented Feb 14, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants