-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inductor] Added non-integer expr support for floordiv in triton codegen #115751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115751
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8f2c7ca with merge base 310f6ab (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vfdev-5
changed the title
[inductor] Added float input support for floordiv in triton codegen
[inductor] Added non-integer expr support for floordiv in triton codegen
Dec 13, 2023
peterbell10
approved these changes
Dec 13, 2023
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
…gen (pytorch#115751) Description: - Added non-integer expr support for floordiv in triton codegen - Added a test - cpp test is skipped as failing and pytorch#115647 may fix it This PR is fixing compilation error with the following code: ```python import torch def func(x, a): n = (a * 1.234) // 8.234 y = x + n return y cfunc = torch.compile(func, dynamic=True, fullgraph=True) device = "cuda" x = torch.tensor(0, dtype=torch.float32, device=device) a = 33 out = cfunc(x, a) expected = func(x, a) torch.testing.assert_close(out, expected) ``` Error message on Nightly: ``` File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result raise self._exception torch._dynamo.exc.BackendCompilerFailed: backend='compile_fx_wrapper' raised: CompilationError: at 7:38:def triton_(in_ptr0, out_ptr0, ks0, xnumel, XBLOCK : tl.constexpr): xoffset = tl.program_id(0) * XBLOCK xindex = xoffset + tl.arange(0, XBLOCK)[:] xmask = xindex < xnumel x0 = xindex tmp0 = tl.load(in_ptr0 + (x0), xmask) tmp1 = ((1.23400000000000*ks0) // 8.23400000000000) ^ AssertionError() ``` Pull Request resolved: pytorch#115751 Approved by: https://github.com/peterbell10
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…gen (pytorch#115751) Description: - Added non-integer expr support for floordiv in triton codegen - Added a test - cpp test is skipped as failing and pytorch#115647 may fix it This PR is fixing compilation error with the following code: ```python import torch def func(x, a): n = (a * 1.234) // 8.234 y = x + n return y cfunc = torch.compile(func, dynamic=True, fullgraph=True) device = "cuda" x = torch.tensor(0, dtype=torch.float32, device=device) a = 33 out = cfunc(x, a) expected = func(x, a) torch.testing.assert_close(out, expected) ``` Error message on Nightly: ``` File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result raise self._exception torch._dynamo.exc.BackendCompilerFailed: backend='compile_fx_wrapper' raised: CompilationError: at 7:38:def triton_(in_ptr0, out_ptr0, ks0, xnumel, XBLOCK : tl.constexpr): xoffset = tl.program_id(0) * XBLOCK xindex = xoffset + tl.arange(0, XBLOCK)[:] xmask = xindex < xnumel x0 = xindex tmp0 = tl.load(in_ptr0 + (x0), xmask) tmp1 = ((1.23400000000000*ks0) // 8.23400000000000) ^ AssertionError() ``` Pull Request resolved: pytorch#115751 Approved by: https://github.com/peterbell10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: inductor
open source
release notes: inductor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is fixing compilation error with the following code:
Error message on Nightly:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler