Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci, docs: add linkcheck job, fix links #1705

Merged
merged 12 commits into from
Mar 5, 2021
Merged

ci, docs: add linkcheck job, fix links #1705

merged 12 commits into from
Mar 5, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Feb 25, 2021 •
edited
Loading

Fixes #1704

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff ydcjeff marked this pull request as draft February 25, 2021 16:37
@ydcjeff ydcjeff marked this pull request as ready for review March 5, 2021 13:02
@ydcjeff ydcjeff changed the title ci, docs: add linkcheck job, fix links [blocked by #1119] ci, docs: add linkcheck job, fix links Mar 5, 2021
ydcjeff
ydcjeff commented Mar 5, 2021
View reviewed changes
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 5, 2021

@vfdev-5
ready to review!

vfdev-5
vfdev-5 reviewed Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @ydcjeff !
I left a comment.

.github/workflows/docs.yml Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @ydcjeff !
Hopefully, we should now have our link correct

@vfdev-5 vfdev-5 merged commit 521e8f2 into pytorch:master Mar 5, 2021
@ydcjeff ydcjeff deleted the ci-linkcheck branch March 5, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some external links are broken
2 participants
@ydcjeff @vfdev-5