Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date and Release fields should be removed from prev_branch's whatsnew when creating new_branch's whatsnew #34

Closed
zware opened this issue Jan 3, 2023 · 2 comments · Fixed by #52
Closed

Date and Release fields should be removed from prev_branch's whatsnew when creating new_branch's whatsnew #34

zware opened this issue Jan 3, 2023 · 2 comments · Fixed by #52
Labels
bug help wanted

Comments

@zware
Copy link
Member

zware commented Jan 3, 2023

Somewhere around

release-tools/run_release.py

Lines 865 to 870 in a8894a3

prev_branch = f"{release_tag.major}.{release_tag.minor}"
new_branch = f"{release_tag.major}.{int(release_tag.minor)+1}"
whatsnew_file = f"Doc/whatsnew/{new_branch}"
with cd(db["git_repo"]), open(whatsnew_file, "w") as f:
f.write(WHATS_NEW_TEMPLATE.format(version=new_branch, prev_version=prev_branch))

we can automatically remove the :Release: and :Date: fields from the previous branch's whatsnew to avoid issues like python/cpython#100700 and python/cpython#73905.
@zware zware mentioned this issue Jan 3, 2023
Closed
@oliver-rew
Copy link
Contributor

Any qualms with me taking this one?

@oliver-rew oliver-rew mentioned this issue Jul 22, 2023
Merged
oliver-rew added a commit to oliver-rew/cpython that referenced this issue Jul 22, 2023
@oliver-rew
fix: remove Release and Date fields from whatsnew
a7844e0 
python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.
@oliver-rew oliver-rew mentioned this issue Jul 22, 2023
Merged
oliver-rew pushed a commit to oliver-rew/cpython that referenced this issue Jul 22, 2023
fix: remove Release and Date fields from whatsnew
67c7cf0 
python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.
oliver-rew pushed a commit to oliver-rew/release-tools that referenced this issue Jul 22, 2023
fix: remove "Release" and "Date" from whatsnew
71d9345 
The "Release" and "Date" fields are no longer needed in the What's New
pages, so I removed them from the template.

python#34
python/cpython#106967
@hugovk
Copy link
Member

hugovk commented Jul 22, 2023

Please go ahead, thank you!

@oliver-rew oliver-rew mentioned this issue Jul 22, 2023
Merged
oliver-rew added a commit to oliver-rew/cpython that referenced this issue Jul 22, 2023
@oliver-rew
fix: remove Release and Date fields from whatsnew
e888452 
python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.
oliver-rew added a commit to oliver-rew/release-tools that referenced this issue Jul 22, 2023
@oliver-rew
fix: remove "Release" and "Date" from whatsnew
0acd795 
The "Release" and "Date" fields are no longer needed in the What's New
pages, so I removed them from the template.

python#34
python/cpython#106967
hugovk pushed a commit to hugovk/cpython that referenced this issue Sep 21, 2023
@oliver-rew @hugovk
fix: remove Release and Date fields from whatsnew
126e306 
python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.
This was referenced Sep 21, 2023
Merged
Closed
Yhg1s pushed a commit to python/cpython that referenced this issue Sep 22, 2023
@hugovk @oliver-rew
[3.12] gh-106967: remove Release and Date fields from whatsnew for 3.…
c03ed79 
…12 (#109648)

fix: remove Release and Date fields from whatsnew

python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.

Co-authored-by: Oliver Rew <orew@bloomberg.net>
github-actions bot pushed a commit to m-aciek/python-docs-weblate that referenced this issue Sep 24, 2023
[3.12] gh-106967: remove Release and Date fields from whatsnew for 3.…
6d736e5 
…12 (#109648)

fix: remove Release and Date fields from whatsnew

python/release-tools template for "What's New" page automatically adds
a "Release" field and a "Date" field with the date set to "today", which
becomes the day the docs are built, which is forever increasing. This is
the topic of python/release-tools#34 which is
yet to be fixed. In the meantime, this commit fixes it manually.

Co-authored-by: Oliver Rew <orew@bloomberg.net>

CPython-sync-commit: c03ed79f22655ff7b9576f66d405da6cf961d911
@ambv ambv closed this as completed in #52 Oct 2, 2023
ambv pushed a commit that referenced this issue Oct 2, 2023
@oliver-rew
fix: remove "Release" and "Date" from whatsnew (#52)
6c6a5d9 
The "Release" and "Date" fields are no longer needed in the What's New
pages, so I removed them from the template.

#34
python/cpython#106967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-34: remove "Release" and "Date" from whatsnew oliver-rew/release-tools
4 participants
@hugovk @zware @oliver-rew @ezio-melotti