Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 735: Draft 2 of Dependency Groups in pyproject.toml #3566

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

sirosen
Copy link
Contributor

@sirosen sirosen commented Dec 5, 2023

The major changes are as follows:

  • remove support for path dependencies (!)
  • include a reference implementation
  • move 'use cases' into appendix
  • rephrase position vis-a-vis Poetry and PDM, and move details of those tools into an appendix
  • include more example data throughout
  • explicitly address the lack of standardization around "reserved names" for Dependency Groups in several places

This revision should be shorter as well. Some redundant and wordy sections have been struck or rewritten.


  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--3566.org.readthedocs.build/

The major changes are as follows:
- remove support for path dependencies (!)
- include a reference implementation
- move 'use cases' into appendix
- rephrase position vis-a-vis Poetry and PDM, and move details
  of those tools into an appendix
- include more example data throughout
- explicitly address the lack of standardization around "reserved
  names" for Dependency Groups in several places

This revision should be shorter as well. Some redundant and wordy
sections have been struck or rewritten.
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifications to make along with fixing a reST CI failure.

peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Outdated Show resolved Hide resolved
peps/pep-0735.rst Show resolved Hide resolved
sirosen and others added 3 commits December 5, 2023 17:52
Co-authored-by: Brett Cannon <brett@python.org>
Better state that requirement lists contain `list[str|dict]`, and be
consistent about calling TOML tables "tables" throughout, rather than
"objects".
@brettcannon
Copy link
Member

The content looks good, but unfortunately CI is still failing.

@sirosen
Copy link
Contributor Author

sirosen commented Dec 6, 2023

It was snarled over some malformed TOML which I had written. It was a pretty small tweak to fix, but hard to spot by eye.

@brettcannon brettcannon merged commit 2a8ea31 into python:main Dec 6, 2023
6 checks passed
@sirosen sirosen deleted the draft2-735 branch December 6, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants