Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) #96034

Merged
merged 1 commit into from
Aug 17, 2022
Merged

gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) #96034

merged 1 commit into from
Aug 17, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 16, 2022 •
edited by bedevere-bot
Loading

@tiran tiran requested a review from pablogsal August 16, 2022 20:04
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 16, 2022
@tiran
Copy link
Member Author

tiran commented Aug 16, 2022 •
edited
Loading

Problem: FreeBSD has ENOTCAPABLE, too. This means that the original changeset maps ENOTCAPABLE to PermissionError on FreeBSD as well. We never wrapped the errno, so it should be ok.

     93	ENOTCAPABLE Capabilities insufficient.	An operation on	a capability
	     file descriptor requires greater privilege	than the capability
	     allows.

https://www.freebsd.org/cgi/man.cgi?query=errno&sektion=2&manpath=freebsd-release-ports

@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 16, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 0e36363 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@tiran tiran changed the title gh-96005: FreeBSD has ENOTCAPABLE, too gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) Aug 17, 2022
@tiran tiran merged commit da0aa51 into python:main Aug 17, 2022
@tiran tiran deleted the gh-96005-bsd branch August 17, 2022 05:24
@tiran tiran added the needs backport to 3.11 only security fixes label Aug 17, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da0aa518bf5e6ac9de444a405c40649cfb0245eb 3.11

@tiran tiran removed the needs backport to 3.11 only security fixes label Aug 17, 2022
tiran added a commit to tiran/cpython that referenced this pull request Aug 17, 2022
@tiran
pythongh-96005: FreeBSD has ENOTCAPABLE, too (pythonGH-96034)
5f4adff
tiran added a commit that referenced this pull request Sep 13, 2022
@tiran
[3.11] gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) (GH-96034
bc337a7 
) (GH-96038)

- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
  files `pybuilddir.txt` and `pyenv.cfg`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

@tiran tiran

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @bedevere-bot @miss-islington