Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91210: Improve error message when non-default param follows default #95933

Merged
merged 5 commits into from
Sep 17, 2022
Merged

gh-91210: Improve error message when non-default param follows default #95933

merged 5 commits into from
Sep 17, 2022

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Aug 12, 2022 •
edited by miss-islington
Loading

  • Improve error message when parameter without a default follows one with a default
  • Show same error message when positional-only params precede the default/non-default sequence

Automerge-Triggered-By: GH:lysnikolaou

@lysnikolaou
pythongh-91210: Improve error message when non-default param follows …
ce567f3 
…default

- Improve error message when parameter without a default follows one
  with a default
- Show same error message when positional-only params precede the
  default/non-default sequence
@lysnikolaou
Copy link
Contributor Author

@pablogsal Very slight nudge on this.

pablogsal
pablogsal approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit on the commit message.

Thanks for working on this 🚀

@lysnikolaou
Copy link
Contributor Author

@pablogsal I guess we're not backporting this, correct?

@miss-islington miss-islington merged commit 7e36abb into python:main Sep 17, 2022
@lysnikolaou lysnikolaou deleted the gh91210-default-arguments-error-message branch September 17, 2022 17:09
@pablogsal
Copy link
Member

pablogsal commented Sep 17, 2022 •
edited
Loading

@pablogsal I guess we're not backporting this, correct?

Unfortunately, we cannot backport it, since it's technically an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @bedevere-bot @miss-islington