Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95205: Improve WASM README.md (GH-95267) #95267

Merged
merged 2 commits into from
Jul 26, 2022
Merged

gh-95205: Improve WASM README.md (GH-95267) #95267

merged 2 commits into from
Jul 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot
Loading

  • drop emrun
  • add build and debug instructions for WASI
  • add wasi-env helper script

@tiran
pythongh-95205: Improve WASM README.md
711aef8 
- drop ``emrun``
- add build and debug instructions for WASI
- add wasi-env helper script
erlend-aasland
erlend-aasland approved these changes Jul 26, 2022
View reviewed changes
Tools/wasm/README.md Outdated Show resolved Hide resolved
Tools/wasm/README.md Show resolved Hide resolved
Tools/wasm/README.md Show resolved Hide resolved
Tools/wasm/README.md Show resolved Hide resolved
@tiran @erlend-aasland
Add full stop
dcd3e0e 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@tiran
Copy link
Member Author

tiran commented Jul 26, 2022

I have been using double ticks for code in MD for years. They work fine.

@tiran
Copy link
Member Author

tiran commented Jul 26, 2022

I'm keeping the double backticks because a) muscle memory, b) consistency with rest of the document, c) they work. :)

@tiran tiran changed the title gh-95205: Improve WASM README.md gh-95205: Improve WASM README.md (GH-95267) Jul 26, 2022
@tiran tiran merged commit e8f3e8f into python:main Jul 26, 2022
@tiran tiran deleted the gh-95205 branch July 26, 2022 09:12
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2022
@tiran @miss-islington
pythongh-95205: Improve WASM README.md (pythonGH-95267)
d7cbabb 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit e8f3e8f)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

GH-95270 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2022
ambv pushed a commit that referenced this pull request Jul 26, 2022
@miss-islington @tiran
gh-95205: Improve WASM README.md (GH-95267) (GH-95270)
6284f23 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit e8f3e8f)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @miss-islington @bedevere-bot @erlend-aasland