Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-15817: Expose command documentation to gdb help #6384

Merged
merged 2 commits into from
Apr 5, 2018
Merged

bpo-15817: Expose command documentation to gdb help #6384

merged 2 commits into from
Apr 5, 2018
+25 −11

Conversation

smontanaro
Copy link
Contributor

@smontanaro smontanaro commented Apr 5, 2018 •
edited by bedevere-bot
Loading

@smontanaro smontanaro changed the title tweaks to issue15817 issue15817 Apr 5, 2018
@smontanaro smontanaro changed the title issue15817 tweaks to bpo-15817 Apr 5, 2018
serhiy-storchaka
serhiy-storchaka reviewed Apr 5, 2018
View reviewed changes
Misc/gdbinit Outdated
@@ -148,7 +160,9 @@ define pystackv
select-frame 0
end

# generally useful macro to print a Unicode string
document pu
Generally useful macro to print a Unicode string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation.

@smontanaro
Copy link
Contributor Author

smontanaro commented Apr 5, 2018 via email

@ned-deily ned-deily changed the title tweaks to bpo-15817 bpo-15817: Expose command documentation to gdb help Apr 5, 2018
@ned-deily ned-deily merged commit 7286dbd into python:master Apr 5, 2018
@The-Compiler The-Compiler mentioned this pull request Jul 30, 2019
Merged
zware pushed a commit that referenced this pull request Sep 9, 2019
@The-Compiler @zware
bpo-15817: gdbinit: Document commands after defining them (GH-15021)
1f86fdc 
The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in GH-6384.
zware pushed a commit to zware/cpython that referenced this pull request Sep 9, 2019
@The-Compiler @zware
[3.8] bpo-15817: gdbinit: Document commands after defining them (pyth…
8a5623b 
…onGH-15021)

The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in pythonGH-6384.
(cherry picked from commit 1f86fdc)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@zware zware mentioned this pull request Sep 9, 2019
Merged
zware added a commit that referenced this pull request Sep 9, 2019
@zware
[3.8] bpo-15817: gdbinit: Document commands after defining them (GH-1…
14f7de7 
…5021) (#15744)

The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in GH-6384.
(cherry picked from commit 1f86fdc)

Authored-by: Florian Bruhin <me@the-compiler.org>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@The-Compiler @lisroach
bpo-15817: gdbinit: Document commands after defining them (pythonGH-1…
c5d1d8f 
…5021)

The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in pythonGH-6384.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@The-Compiler @DinoV
bpo-15817: gdbinit: Document commands after defining them (pythonGH-1…
44ad494 
…5021)

The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in pythonGH-6384.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@The-Compiler @websurfer5
bpo-15817: gdbinit: Document commands after defining them (pythonGH-1…
6c892cb 
…5021)

The gdb manual[1] says the following for "document":

  The command commandname must already be defined.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb/Define.html

And indeed when trying to use the gdbinit file with gdb 8.3, I get:

  .../cpython/Misc/gdbinit:17: Error in sourced command file:
  Undefined command: "pyo".  Try "help".

Fix this by moving all documentation blocks after the define blocks.

This was introduced in pythonGH-6384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smontanaro @serhiy-storchaka @ned-deily @the-knights-who-say-ni @bedevere-bot