Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46316: optimize pathlib.Path.iterdir() #30501

Merged
merged 1 commit into from
Jan 20, 2022
Merged

bpo-46316: optimize pathlib.Path.iterdir() #30501

merged 1 commit into from
Jan 20, 2022

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jan 9, 2022 •
edited
Loading

os.listdir() doesn't return entries for . or .., so we don't need to check for them here.

See https://docs.python.org/3/library/os.html#os.listdir

Return a list containing the names of the entries in the directory given by path. The list is in arbitrary order, and does not include the special entries '.' and '..' even if they are present in the directory.

https://bugs.python.org/issue46316

@barneygale
bpo-46316: optimize pathlib.Path.iterdir()
9c2d09e 
`os.listdir()` doesn't return entries for `.` or `..`, so we don't need to
check for them here.

See https://docs.python.org/3/library/os.html#os.listdir
@barneygale barneygale mentioned this pull request Jan 9, 2022
Closed
@AlexWaygood AlexWaygood added the performance Performance or resource usage label Jan 9, 2022
zware
zware approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; confirmed that both implementations of listdir explicitly elide . and .., and it doesn't look like self._accessor.listdir can be anything other than os.listdir.

@zware zware merged commit a1c8841 into python:main Jan 20, 2022
@barneygale barneygale mentioned this pull request Jun 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barneygale @zware @the-knights-who-say-ni @bedevere-bot @AlexWaygood