bpo-45743: Remove workaround for zlib CVE from 2002 (GH-29457) #29457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-deily
reviewed
Nov 7, 2021
setup.py
Outdated
| else: | ||
| self.missing.append('zlib') | ||
| if MACOS: | ||
| extra_link_args = ('-Wl,-search_paths_first',) |
There was a problem hiding this comment.
We could possibly drop the search_paths_first special case code. That used to be necessary to have the macOS linker search for shared libraries in all search paths first before searching for static libs and this was potentially useful if you were trying to override a third-party library provided by macOS. But the default changed as of Xcode 4, according to the macOS ld(1) man page which was around MacOS 10.6, so that search_paths_first is now the normal behavior. Certainly it shouldn't need to be there if it is possible to specify lib paths via pkg-config. @ronaldoussoren, your thoughts?
Signed-off-by: Christian Heimes <christian@python.org>
tiran
changed the title
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45743