Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test exceptions: test_range_of_offsets() - add check against expected #28484

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Test exceptions: test_range_of_offsets() - add check against expected #28484

merged 1 commit into from
Sep 21, 2021

Conversation

akulakov
Copy link
Contributor

The expected tracebacks were added to the test but not checked against actual tracebacks.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2021
@ambv ambv merged commit a007347 into python:main Sep 21, 2021
@miss-islington
Copy link
Contributor

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2021
@akulakov @miss-islington
[tests] Add missing assert against expected tracebacks in test_except…
305efdd 
…ions.py (pythonGH-28484)

(cherry picked from commit a007347)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @akulakov and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a0073471002bed0169fb806703e26880bbcceb73 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 21, 2021
@bedevere-bot
Copy link

GH-28510 is a backport of this pull request to the 3.10 branch.

@ambv ambv removed the needs backport to 3.9 only security fixes label Sep 21, 2021
@ambv
Copy link
Contributor

ambv commented Sep 21, 2021 •
edited
Loading

Backport to 3.9 impossible as this is a new test in 3.10.

ambv pushed a commit that referenced this pull request Sep 21, 2021
@miss-islington @akulakov
[tests] Add missing assert against expected tracebacks in test_except…
c800e39 
…ions.py (GH-28484) (GH-28510)

(cherry picked from commit a007347)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akulakov @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni