Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-19113: remove unused test_errors #28008

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Aug 27, 2021

This test was added as part of commit:
babddfc

It was added alongside a test with the same name at line 300. Therefore, this test can be removed as it was never used because was always shadowed by the second test; and because it is failing now when enabled.

It should be removed to avoid confusion and test failures if second test is ever moved or renamed.

https://bugs.python.org/issue19113

@ambv
Copy link
Contributor

ambv commented Sep 8, 2021

@iceman201, please don't approve pull requests in this repository. It's noise because it's not something we take into account if you're not a contributor.

@ambv ambv merged commit a561005 into python:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants