bpo-44544: add textwrap placeholder arg #27671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
|
Looks off: |
|
@MaxwellDupre It looks a bit better if there is a leading space (and consistent with existing placeholder default in this module): my line of text[...] |
asvetlov
added
needs backport to 3.9
asvetlov
approved these changes
Mar 19, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 19, 2022
(cherry picked from commit cb7874f) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 19, 2022
(cherry picked from commit cb7874f) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
|
GH-31992 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-31993 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 19, 2022
miss-islington
added a commit
that referenced
this pull request
Mar 19, 2022
|
@MaxwellDupre @asvetlov thanks for reviewing! |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
(cherry picked from commit cb7874f) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small follow up fix to the linked issue -- add placeholder arg which does have effect in these 2 functions.
https://bugs.python.org/issue44544