bpo-44608: Fix memory leak in _tkinter._flatten() #27107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it is called with a sequence or set, but not list or tuple.
serhiy-storchaka
added
type-bug
Lib/test/test_types.py
Outdated
| @@ -649,17 +661,37 @@ def test_or_types_operator(self): | |||
| 3 | int | |||
| with self.assertRaises(TypeError): | |||
| Example() | int | |||
| x = int | str | |||
There was a problem hiding this comment.
I think you accidentally copied over these tests from another branch 😅 . They seem to be for another bug.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-27133 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2021
if it is called with a sequence or set, but not list or tuple. (cherry picked from commit f572cbf) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-27134 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2021
if it is called with a sequence or set, but not list or tuple. (cherry picked from commit f572cbf) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2021
miss-islington
added a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if it is called with a sequence or set, but not list or tuple.
https://bugs.python.org/issue44608