Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44535: Enable building with Visual Studio 2022 on Windows #26962

Merged
merged 1 commit into from
Jun 30, 2021
Merged

bpo-44535: Enable building with Visual Studio 2022 on Windows #26962

merged 1 commit into from
Jun 30, 2021

Conversation

zooba
Copy link
Member

@zooba zooba commented Jun 30, 2021 •
edited by bedevere-bot
Loading

@zooba zooba added OS-windows needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 30, 2021
@zooba zooba requested a review from a team as a code owner June 30, 2021 01:36
@zooba
Copy link
Member Author

zooba commented Jun 30, 2021

Note that there's a typo in the commit message, which will need to be fixed before merging (unless another commit is added, though that seems unlikely).

@zooba zooba merged commit d3a95c1 into python:main Jun 30, 2021
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-44535 branch June 30, 2021 19:06
@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d3a95c1b6eacbbbd92c294744e7ed41932f3f63e 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2021
@zooba @miss-islington
bpo-44535: Enable building with Visual Studio 2022 on Windows (python…
d13d7b5 
…GH-26962)

(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba removed the needs backport to 3.10 only security fixes label Jun 30, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 30, 2021
@bedevere-bot
Copy link

GH-26975 is a backport of this pull request to the 3.9 branch.

@zooba zooba added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 30, 2021
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2021
@zooba @miss-islington
bpo-44535: Enable building with Visual Studio 2022 on Windows (python…
97e2dc8 
…GH-26962)

(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-26976 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 30, 2021
miss-islington added a commit that referenced this pull request Jun 30, 2021
@miss-islington @zooba
bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
6843a3b 
(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Jun 30, 2021
@miss-islington @zooba
bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
67e3945 
(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
needs backport to 3.9 only security fixes OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni