Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__ #25818

Merged
merged 2 commits into from
May 2, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 2, 2021

Both sqlite3.connect() and sqlite.Connection() now produce sqlite3.connect* events.

https://bugs.python.org/issue43434

@erlend-aasland
Copy link
Contributor Author

@berkerpeksag: I'm not sure if we should change the docs. Explicitly using the sqlite3.Connection.__init__ constructor to create connections is currently an undocumented feature.

@erlend-aasland
Copy link
Contributor Author

cc. @zooba

@erlend-aasland
Copy link
Contributor Author

@pablogsal Is it possible to get this into beta1? It contains a bugfix for GH-25246.

@zooba zooba merged commit c96cc08 into python:master May 2, 2021
@zooba zooba added the needs backport to 3.9 only security fixes label May 2, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c96cc089f60d2bf7e003c27413c3239ee9de2990 3.9

@erlend-aasland erlend-aasland deleted the sqlite-improve-connection-audit branch May 2, 2021 21:29
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request May 2, 2021
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request May 2, 2021
…ion.__init__ (pythonGH-25818).

(cherry picked from commit c96cc08)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-25822 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 2, 2021
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request May 2, 2021
…ion.__init__ (pythonGH-25818).

(cherry picked from commit c96cc08)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2021
…nit__ (pythonGH-25818)

(cherry picked from commit ad73d16)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
zooba pushed a commit that referenced this pull request May 2, 2021
…init__ (GH-25818)

(cherry picked from commit c96cc08)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants