Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43415: Fix typo on dataclasses.rst #24789

Merged
merged 1 commit into from
Mar 8, 2021
Merged

bpo-43415: Fix typo on dataclasses.rst #24789

merged 1 commit into from
Mar 8, 2021

Conversation

gmcrocetti
Copy link
Contributor

@gmcrocetti gmcrocetti commented Mar 8, 2021 •
edited
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@gmcrocetti

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 8, 2021
@gmcrocetti
Copy link
Contributor Author

CLA has been signed

@ericvsmith ericvsmith added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes and removed CLA not signed labels Mar 8, 2021
@ericvsmith ericvsmith merged commit 0554044 into python:master Mar 8, 2021
@bedevere-bot
Copy link

@ericvsmith: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @gmcrocetti for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24790 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 8, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2021
@gmcrocetti @miss-islington
bpo-43415: Fix typo on dataclasses.rst (pythonGH-24789)
b906fca 
(cherry picked from commit 0554044)

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Mar 8, 2021
@bedevere-bot
Copy link

GH-24791 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2021
@gmcrocetti @miss-islington
bpo-43415: Fix typo on dataclasses.rst (pythonGH-24789)
f9d57db 
(cherry picked from commit 0554044)

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>
ericvsmith pushed a commit that referenced this pull request Mar 8, 2021
@miss-islington @gmcrocetti
bpo-43415: Fix typo on dataclasses.rst (GH-24789) (GH-24790)
fb3b031 
(cherry picked from commit 0554044)

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>
ericvsmith pushed a commit that referenced this pull request Mar 8, 2021
@miss-islington @gmcrocetti
bpo-43415: Fix typo on dataclasses.rst (GH-24789) (GH-24791)
6d42733 
(cherry picked from commit 0554044)

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>

Co-authored-by: Guilherme Martins Crocetti <gmcrocetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmcrocetti @the-knights-who-say-ni @bedevere-bot @miss-islington @iritkatriel @ericvsmith