Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41195: Add getter for Openssl security level #21282

Conversation

matthewhughes934
Copy link
Contributor

@matthewhughes934 matthewhughes934 commented Jul 2, 2020

Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html


This is my first time contributing, so please pull me up on all the things I missed or did incorrectly.

https://bugs.python.org/issue41195

Automerge-Triggered-By: @tiran

Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@matthewhughes934

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tiran
Copy link
Member

tiran commented Jul 2, 2020

Thanks! You need to do three things:

  • sign the CLA
  • add a news entry. You can either use blurb-it bot or the blurb tool
  • update documentation Doc/library/ssl.rst including versionadded

@matthewhughes934
Copy link
Contributor Author

Thanks tiran,

sign the CLA

Done, from what I understand it's now just a waiting game for it to be picked up by the system

add a news entry. You can either use blurb-it bot or the blurb tool
update documentation Doc/library/ssl.rst including versionadded

Thanks, added these too.

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I have two small requests for documentation.

Doc/library/ssl.rst Outdated Show resolved Hide resolved
Doc/library/ssl.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran tiran self-assigned this Jul 5, 2020
@matthewhughes934
Copy link
Contributor Author

Thanks for the suggestions, I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran July 5, 2020 17:17
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@matthewhughes934
Copy link
Contributor Author

Not sure what's holding up the Travis check; it looks like the job for the latest commit passed ok. Hopefully it will just sort itself out in time.

@matthewhughes934
Copy link
Contributor Author

@tiran Thanks again for helping with my first contribution!

I'm a bit worried the Travis check here might be stuck, the build looks to have run successfully in a reasonable time, but the status on Github has not been updated for some days now. Is there some way to force this to update/refresh?

@matthewhughes934
Copy link
Contributor Author

🤔 I might try closing and reopening to see if that gets Travis going again.

@miss-islington
Copy link
Contributor

@matthewhughes934: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8e836bb into python:master Jul 17, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html


------
This is my first time contributing, so please pull me up on all the things I missed or did incorrectly.

Automerge-Triggered-By: @tiran
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html


------
This is my first time contributing, so please pull me up on all the things I missed or did incorrectly.

Automerge-Triggered-By: @tiran
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html


------
This is my first time contributing, so please pull me up on all the things I missed or did incorrectly.

Automerge-Triggered-By: @tiran
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Add an accessor under SSLContext.security_level as a wrapper around
SSL_CTX_get_security_level, see:
https://www.openssl.org/docs/manmaster/man3/SSL_CTX_get_security_level.html


------
This is my first time contributing, so please pull me up on all the things I missed or did incorrectly.

Automerge-Triggered-By: @tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants