Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow macOS installer builds to package pre-built html docs #20715

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Jun 8, 2020

The macOS build-installer script now looks in its directory of
source tarballs for a suitable html tarball of the same version.
If found, it will unpack and use it rather than rebuilding the html
format documentation set from the source repo.
This is intended as a speedup for test builds of the installer.
Files names must be in the same format as produced by the
docs build for download, for example,
python-3.9.0b1-docs-html.tar.bz2.

build-installer now looks in its directory of source tarballs
for a suitable html tarball of the same version.  If so, it
will unpack and use it rather than rebuilding the html format
documentation set from the source repo.  This is intended as
a speedup for test builds of the installer.  Files names must
be in the same format as produced by the docs build for download,
for example, `python-3.9.0b1-docs-html.tar.bz2`.
@miss-islington
Copy link
Contributor

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2020
…-20715)

build-installer now looks in its directory of source tarballs
for a suitable html tarball of the same version.  If so, it
will unpack and use it rather than rebuilding the html format
documentation set from the source repo.  This is intended as
a speedup for test builds of the installer.  Files names must
be in the same format as produced by the docs build for download,
for example, `python-3.9.0b1-docs-html.tar.bz2`.
(cherry picked from commit 63fc55b)

Co-authored-by: Ned Deily <nad@python.org>
@bedevere-bot
Copy link

GH-20716 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 8, 2020
@miss-islington
Copy link
Contributor

Sorry, @ned-deily, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 63fc55b2eab0331465605a49bfd28a1bcb997f92 3.8

@miss-islington
Copy link
Contributor

Sorry @ned-deily, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 63fc55b2eab0331465605a49bfd28a1bcb997f92 3.7

miss-islington added a commit that referenced this pull request Jun 8, 2020
build-installer now looks in its directory of source tarballs
for a suitable html tarball of the same version.  If so, it
will unpack and use it rather than rebuilding the html format
documentation set from the source repo.  This is intended as
a speedup for test builds of the installer.  Files names must
be in the same format as produced by the docs build for download,
for example, `python-3.9.0b1-docs-html.tar.bz2`.
(cherry picked from commit 63fc55b)

Co-authored-by: Ned Deily <nad@python.org>
@ned-deily ned-deily deleted the installer_use_cached_docs branch June 9, 2020 17:08
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
…-20715)

build-installer now looks in its directory of source tarballs
for a suitable html tarball of the same version.  If so, it
will unpack and use it rather than rebuilding the html format
documentation set from the source repo.  This is intended as
a speedup for test builds of the installer.  Files names must
be in the same format as produced by the docs build for download,
for example, `python-3.9.0b1-docs-html.tar.bz2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants