-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-123923: Defer refcounting for f_executable
in _PyInterpreterFrame
#123924
Conversation
…terFrame` Use a `_PyStackRef` and defer the reference to `f_executable` when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust that you've run this with refleak tests? When I attempted this, there were a ton of refleaks.
Also one question. The rest looks good to me!
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9e7691a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense now. Just one comment.
Use a
_PyStackRef
and defer the reference tof_executable
when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build._PyInterpreterFrame
fields #123923