Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-123091: Use _Py_IsImmortalLoose() (#123511) #123600

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 2, 2024

Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c and ceval.c.

(cherry picked from commit f1a0d96)

Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c
and ceval.c.

(cherry picked from commit f1a0d96)
@vstinner
Copy link
Member Author

vstinner commented Sep 2, 2024

@encukou: Would you mind to review this backport to 3.13?

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

@vstinner
Copy link
Member Author

vstinner commented Sep 2, 2024

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

If tomorrow, more issues will be open about this problem, I would suggest considering to change _Py_IsImmortal() to behave as _Py_IsImmortalLoose(). But for now, I prefer smaller changes by using _Py_IsImmortalLoose() instead.

@vstinner vstinner merged commit 10735bf into python:3.13 Sep 2, 2024
57 of 58 checks passed
@vstinner vstinner deleted the bytes_immortal_loose13 branch September 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants