Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123048: Fix missing source location in pattern matching code #123167

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 20, 2024

Threading doesn't work for JUMP_NO_INTERRUPT. In this case it doesn't need to be JUMP_NO_INTERRUPT anyway because it's a forward jump so it makes no difference to the final bytecode.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean fix.

@iritkatriel iritkatriel merged commit bffed80 into python:main Aug 20, 2024
40 checks passed
@iritkatriel iritkatriel added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 20, 2024
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 20, 2024
…pythonGH-123167)

(cherry picked from commit bffed80)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

GH-123169 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 20, 2024
…pythonGH-123167)

(cherry picked from commit bffed80)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 20, 2024

GH-123170 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Aug 20, 2024
iritkatriel added a commit that referenced this pull request Aug 20, 2024
GH-123167) (#123169)

gh-123048: Fix missing source location in pattern matching code (GH-123167)
(cherry picked from commit bffed80)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Sep 6, 2024
GH-123167) (#123170)

gh-123048: Fix missing source location in pattern matching code (GH-123167)
(cherry picked from commit bffed80)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants