Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105376: Restore deprecated logging warn() method #122775

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 7, 2024

This reverts commit dcc028d and commit 6c54e5d.

Keep the deprecated logging warn() method in Python 3.13.


📚 Documentation preview 📚: https://cpython-previews--122775.org.readthedocs.build/

This reverts commit dcc028d and
commit 6c54e5d.

Keep the deprecated logging warn() method in Python 3.13.
@hugovk
Copy link
Member

hugovk commented Aug 7, 2024

We have some new pages for deprecations, see:

These RSTs are .. include::d on https://docs.python.org/3.14/deprecations/index.html and in the What's New pages such as https://docs.python.org/3.14/whatsnew/3.14.html#pending-removal-in-python-3-15 and https://docs.python.org/3.14/whatsnew/3.13.html#pending-removal-in-python-3-15 (and so on) to avoid duplication.

Please could you list these deprecations in one of those files? I guess we're not setting a version in which to remove? In which case, "Pending Removal in Future Versions":

@AA-Turner
Copy link
Member

I do wonder if we should be more explicit in documentation, or improve the warning some other way? This is a very long-standing deprecation warning, so clearly users are not seeing it.

A crude search (using [^es] to exclude warnings.warn and console.warn) gives ~180k files with .warn( and 1M+ files with .warning(.

A

@hugovk
Copy link
Member

hugovk commented Aug 7, 2024

There's a lot of false positives in there.

A narrower search in the top 8k PyPI projects:

Found 136 matching lines in 53 projects
python3 ~/github/misc/cpython/search_pypi_top.py -q . "logging\.warn\b"
./anyconfig-0.14.0.tar.gz: anyconfig-0.14.0/NEWS: - change: replace logging.warn with warnings.warn, and remove other logging code
./behave-1.2.6.tar.gz: behave-1.2.6/tests/issues/test_issue0495.py: logging.warn(message)
./dirac-8.0.49.tar.gz: dirac-8.0.49/release.notes: FIX: (#4956) use logging.warning in favor of deprecated logging.warn
./distrax-0.1.5.tar.gz: distrax-0.1.5/distrax/_src/utils/transformations.py: logging.warn("[Distrax]: the '%s' primitive can exhibit unstable "
./apache-superset-4.0.1.tar.gz: apache-superset-4.0.1/superset/migrations/versions/2019-11-06_15-23_78ee127d0d1d_reconvert_legacy_filters_into_adhoc.py: logging.warn(ex)
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/PKG-INFO: logging.warn(f'Missing config for "{type_}". Discarding block, keeping content.')
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/PKG-INFO: logging.warn(f'Missing config for "{type_}". Using div instead.')
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/README.md: logging.warn(f'Missing config for "{type_}". Discarding block, keeping content.')
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/README.md: logging.warn(f'Missing config for "{type_}". Using div instead.')
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/draftjs_exporter.egg-info/PKG-INFO: logging.warn(f'Missing config for "{type_}". Discarding block, keeping content.')
./draftjs_exporter-5.0.0.tar.gz: draftjs_exporter-5.0.0/draftjs_exporter.egg-info/PKG-INFO: logging.warn(f'Missing config for "{type_}". Using div instead.')
./appengine-python-standard-1.1.6.tar.gz: appengine-python-standard-1.1.6/src/google/appengine/_internal/protorpc/gen_protorpc.py: logging.warn('Will not generate descriptor without package name')
./appengine-python-standard-1.1.6.tar.gz: appengine-python-standard-1.1.6/src/google/appengine/_internal/protorpc/gen_protorpc.py: logging.warn('Will not generate main ProtoRPC class %s' % package)
./appengine-python-standard-1.1.6.tar.gz: appengine-python-standard-1.1.6/src/google/appengine/_internal/protorpc/gen_protorpc.py: logging.warn('Not overwriting %s with package %s',
./appengine-python-standard-1.1.6.tar.gz: appengine-python-standard-1.1.6/src/google/appengine/api/lib_config.py: logging.warn('Configuration "%s" not recognized', self._prefix + key)
./appengine-python-standard-1.1.6.tar.gz: appengine-python-standard-1.1.6/src/google/appengine/ext/ndb/model.py: logging.warn('Skipping unknown structured subproperty (%s) '
./arcgis-2.3.0.3.tar.gz: arcgis-2.3.0.3/arcgis/features/geo/_io/fileops.py: _logging.warn("row %s could not be inserted." % idx)
./arcgis-2.3.0.3.tar.gz: arcgis-2.3.0.3/arcgis/features/geo/_io/fileops.py: _logging.warn(
./decorator-5.1.1.tar.gz: decorator-5.1.1/PKG-INFO: logging.warn('%s took %d seconds', func.__name__, dt)
./decorator-5.1.1.tar.gz: decorator-5.1.1/src/decorator.egg-info/PKG-INFO: logging.warn('%s took %d seconds', func.__name__, dt)
./edk2_pytool_extensions-0.27.8.tar.gz: edk2_pytool_extensions-0.27.8/edk2toolext/environment/uefi_build.py: logging.warn("OUTPUT_DIRECTORY was not found, defaulting to Build")
./edk2_pytool_extensions-0.27.8.tar.gz: edk2_pytool_extensions-0.27.8/edk2toolext/image_validation.py: logging.warn("Section Alignment is not present")
./edk2_pytool_extensions-0.27.8.tar.gz: edk2_pytool_extensions-0.27.8/edk2toolext/invocables/edk2_ci_build.py: logging.warn(f"--->Test Skipped: in plugin! {Descriptor.Name} {target}")
./edk2_pytool_extensions-0.27.8.tar.gz: edk2_pytool_extensions-0.27.8/edk2toolext/omnicache.py: logging.warn("Failed to rename {0}. Attempting to remove it.".format(name))
./edk2_pytool_library-0.21.8.tar.gz: edk2_pytool_library-0.21.8/edk2toollib/os/uefivariablesupport.py: logging.warn(
./fancyimpute-0.7.0.tar.gz: fancyimpute-0.7.0/fancyimpute/common.py: logging.warn("No observed values in column")
./fancyimpute-0.7.0.tar.gz: fancyimpute-0.7.0/setup.py: logging.warn("Failed to load %s" % readme_filename)
./farm_haystack-1.26.2.tar.gz: farm_haystack-1.26.2/haystack/utils/export_utils.py: logging.warn("print_answers received details='%s', which was not understood. ", details)
./farm_haystack-1.26.2.tar.gz: farm_haystack-1.26.2/haystack/utils/export_utils.py: logging.warn("Valid values are %s. Using 'all'.", valid_values)
./gluonts-0.15.1.tar.gz: gluonts-0.15.1/src/gluonts/dataset/common.py: logging.warn(f"Cannot infer loader for {subpath}.")
./feedfinder2-0.0.4.tar.gz: feedfinder2-0.0.4/feedfinder2.py: logging.warn("Error while getting '{0}'".format(url))
./feedfinder2-0.0.4.tar.gz: feedfinder2-0.0.4/feedfinder2.py: logging.warn("{0}".format(e))
./asyncio-3.4.3.tar.gz: asyncio-3.4.3/examples/cacheclt.py: logging.warn('%s Timeout', label)
./asyncio-3.4.3.tar.gz: asyncio-3.4.3/examples/cachesvr.py: logging.warn('Inserting random failure')
./google-apitools-0.5.32.tar.gz: google-apitools-0.5.32/apitools/gen/service_registry.py: logging.warn(
./google-apitools-0.5.32.tar.gz: google-apitools-0.5.32/apitools/gen/service_registry.py: logging.warn('Unexpected MIME type: %s', accept_pattern)
./fido2-1.1.3.tar.gz: fido2-1.1.3/fido2/mds3.py: logging.warn("Matched entry has no metadata_statement, can't validate!")
./google-cloud-0.34.0.tar.gz: google-cloud-0.34.0/setup.py: logging.warn(warning)
./fiona-1.9.6.tar.gz: fiona-1.9.6/setup.py: logging.warn("Failed to get options via gdal-config: %s", str(e))
./google-cloud-logging-3.10.0.tar.gz: google-cloud-logging-3.10.0/google/cloud/logging_v2/client.py: logger, so that a call such as ``logging.warn``, as well as all child
./lhotse-1.24.2.tar.gz: lhotse-1.24.2/lhotse/workarounds.py: # logging.warn('decompression OK, trailing garbage ignored')
./libcst-1.4.0.tar.gz: libcst-1.4.0/libcst/codemod/commands/tests/test_rename.py: logging.warn(1)
./libcst-1.4.0.tar.gz: libcst-1.4.0/libcst/codemod/commands/tests/test_rename.py: old_name="logging.warn",
./libvirt-python-10.4.0.tar.gz: libvirt-python-10.4.0/ChangeLog: examples: replace logging.warn with logging.warning
./libvirt-python-10.4.0.tar.gz: libvirt-python-10.4.0/ChangeLog: logging.warn is an alias to logging.warning since Python 3.3 and will be
./meshio-5.3.5.tar.gz: meshio-5.3.5/src/meshio/vtk/_vtk_42.py: #     logging.warn("Converting to new byte order")
./meshio-5.3.5.tar.gz: meshio-5.3.5/src/meshio/vtk/_vtk_51.py: #     logging.warn("Converting to new byte order")
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn("queue: " + " ".join(f'{k:08x}' for k in self.queue))
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn(f"packet: {packetId:08x} {packet}")
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn("resentQueue: " + " ".join(f'{k:08x}' for k in resentQueue))
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn("queue + resentQueue: " + " ".join(f'{k:08x}' for k in self.queue))
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn("queue: " + " ".join(f'{k:08x}' for k in self.queue))
./meshtastic-2.3.12.tar.gz: meshtastic-2.3.12/meshtastic/mesh_interface.py: # logging.warn("queue: " + " ".join(f'{k:08x}' for k in self.queue))
./klio-exec-22.3.0.tar.gz: klio-exec-22.3.0/src/klio_exec/commands/run.py: logging.warn(
./klio-exec-22.3.0.tar.gz: klio-exec-22.3.0/src/klio_exec/commands/run.py: logging.warn(
./knnimpute-0.1.0.tar.gz: knnimpute-0.1.0/setup.py: logging.warn("Failed to load %s" % readme_filename)
./knnimpute-0.1.0.tar.gz: knnimpute-0.1.0/setup.py: logging.warn("Conversion of long_description from MD to RST failed")
./mixer-7.2.2.tar.gz: mixer-7.2.2/mixer/markov.py: logging.warn('Database file corrupt or not found, using empty database')
./mixer-7.2.2.tar.gz: mixer-7.2.2/mixer/markov.py: logging.warn('Database file could not be written')
./os-ken-2.9.0.tar.gz: os-ken-2.9.0/ChangeLog: * python 3: Replace deprecated logging.warn with logging.warning
./pylint-3.2.5.tar.gz: pylint-3.2.5/doc/data/messages/d/deprecated-method/bad.py: logging.warn("I'm coming, world !")  # [deprecated-method]
./pylint-3.2.5.tar.gz: pylint-3.2.5/pylint/checkers/stdlib.py: "logging.warn",
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/d/deprecated/deprecated_methods_py3.py: logging.warn("a") # [deprecated-method]
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/d/deprecated/deprecated_methods_py38.py: logging.warn("a") # [deprecated-method]
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/d/deprecated/deprecated_methods_py38.py: deprecated_method = logging.warn
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("%s, %s" % (4, 5))  # [logging-not-lazy]
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("Var: " + var)  # [logging-not-lazy]
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("%s, %s", 4, 5)
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: logging.warn("%s, %s" % (4, 5))
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("%s" + " the rest of a single string")
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("Msg: " + "%s", "first piece " + "second piece")
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn("first" + "second" + "third %s", "parameter")
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy.py: renamed_logging.warn(("first" + "second" + "third %s"))
./pylint-3.2.5.tar.gz: pylint-3.2.5/tests/functional/l/logging/logging_not_lazy_module.py: blogging.warn("%s" % "%s")  # [logging-not-lazy]
./python-gflags-3.1.2.tar.gz: python-gflags-3.1.2/gflags/flagvalues.py: logging.warn(
./python-gflags-3.1.2.tar.gz: python-gflags-3.1.2/gflags2man.py: logging.warn('Never found the start of the flags section for "%s"!'
./pymavlink-2.4.41.tar.gz: pymavlink-2.4.41/mavwp.py: logging.warn(
./rouge_score-0.1.2.tar.gz: rouge_score-0.1.2/rouge_score/io.py: logging.warn("Expected delimiter at end of file")
./rouge_score-0.1.2.tar.gz: rouge_score-0.1.2/rouge_score/io.py: logging.warn("No scores to write")
./pympler-1.1.tar.gz: pympler-1.1/pympler/process.py: logging.warn("Please install pywin32 when using pympler on Windows.")
./ruff-0.5.0.tar.gz: ruff-0.5.0/crates/ruff_linter/src/rules/flake8_logging_format/violations.rs: /// Checks for uses of `logging.warn` and `logging.Logger.warn`.
./ruff-0.5.0.tar.gz: ruff-0.5.0/crates/ruff_linter/src/rules/flake8_logging_format/violations.rs: /// `logging.warn` and `logging.Logger.warn` are deprecated in favor of
./ruff-0.5.0.tar.gz: ruff-0.5.0/crates/ruff_linter/src/rules/flake8_logging_format/violations.rs: /// logging.warn("Something happened")
./ruff-0.5.0.tar.gz: ruff-0.5.0/crates/ruff_linter/src/rules/pygrep_hooks/rules/deprecated_log_warn.rs: ///     logging.warn("Something happened")
./pipreqs-0.5.0.tar.gz: pipreqs-0.5.0/pipreqs/pipreqs.py: logging.warn("Failed on file: %s" % file_name)
./pytest-json-report-1.5.0.tar.gz: pytest-json-report-1.5.0/tests/test_jsonreport.py: logging.warn('log warn')
./pytorchvideo-0.1.5.tar.gz: pytorchvideo-0.1.5/pytorchvideo/layers/accelerator/mobile_cpu/convolutions.py: logging.warn(
./pyre-check-0.9.22.tar.gz: pyre_check-0.9.22/taint/core_privacy_security/logging_sinks.pysa: def logging.warn(
./scandir-1.10.0.tar.gz: scandir-1.10.0/setup.py: logging.warn("building the %s failed with %s", ext.name, exception)
./schema-0.7.7.tar.gz: schema-0.7.7/PKG-INFO: kwargs["handler"] = lambda key, *args: logging.warn(f"`{key}` is deprecated. " + (self._error or ""))
./schema-0.7.7.tar.gz: schema-0.7.7/schema.egg-info/PKG-INFO: kwargs["handler"] = lambda key, *args: logging.warn(f"`{key}` is deprecated. " + (self._error or ""))
./spark-nlp-5.4.0.tar.gz: spark-nlp-5.4.0/sparknlp/training/_tf_graph_builders/tf2contrib/core_rnn_cell.py: logging.warn("%s: The input_size parameter is deprecated.", self)
./spark-nlp-5.4.0.tar.gz: spark-nlp-5.4.0/sparknlp/training/_tf_graph_builders/tf2contrib/rnn_cell.py: logging.warn("%s: Using a concatenated state is slower and will soon be "
./spark-nlp-5.4.0.tar.gz: spark-nlp-5.4.0/sparknlp/training/_tf_graph_builders/tf2contrib/rnn_cell.py: logging.warn("%s: Using a concatenated state is slower and will soon be "
./spark-nlp-5.4.0.tar.gz: spark-nlp-5.4.0/sparknlp/training/_tf_graph_builders/tf2contrib/rnn_cell.py: logging.warn("%s: Using a concatenated state is slower and will soon be "
./spark-nlp-5.4.0.tar.gz: spark-nlp-5.4.0/sparknlp/training/_tf_graph_builders/tf2contrib/rnn_cell.py: logging.warn("%s: The input_size parameter is deprecated.", self)
./workflow-2.1.6.tar.gz: workflow-2.1.6/tests/test_config.py: logging.warn('root warn')
./workflow-2.1.6.tar.gz: workflow-2.1.6/tests/test_config.py: logging.warn('root warn')
./py-1.11.0.tar.gz: py-1.11.0/testing/io_/test_capture.py: logging.warn("hello1")
./py-1.11.0.tar.gz: py-1.11.0/testing/io_/test_capture.py: logging.warn("hello2")
./py-1.11.0.tar.gz: py-1.11.0/testing/io_/test_capture.py: logging.warn("hello3")
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/core/input_reader.py: logging.warn(
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/legacy/image_classification/dataset_factory.py: logging.warn(
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/legacy/image_classification/resnet/resnet_ctl_imagenet_main.py: logging.warn('Setting steps_per_loop to %d to respect epoch boundary.',
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/layers/text_layers.py: logging.warn("Encountered error when importing tensorflow_text: %s", e)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/networks/bert_encoder.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/networks/bert_encoder.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/networks/fnet.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/networks/funnel_transformer.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/nlp/modeling/networks/sparse_mixer.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/projects/bigbird/recompute_grad.py: logging.warn('Resetting the generator. %s: %s', type(e), e)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/projects/movinet/modeling/movinet.py: logging.warn('norm_activation is not used in MoViNets, but specified: '
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/projects/movinet/modeling/movinet.py: logging.warn('norm_activation is ignored.')
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/projects/roformer/roformer_encoder.py: logging.warn(warn_string)
./tf-models-official-2.16.0.tar.gz: tf-models-official-2.16.0/official/projects/yt8m/modeling/yt8m_model.py: logging.warn("Skip build head type: %s", self._params.head.type)
./visdom-0.2.4.tar.gz: visdom-0.2.4/py/visdom/server/app.py: logging.warn(
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/compat.py: tf.compat.v1.logging.warn(
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Export a separated vocab file even though '
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Export a separated label file even though '
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Encountered unknown parameters: ' +
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/task/object_detector.py: tf.compat.v1.logging.warn(
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/core/task/object_detector.py: tf.compat.v1.logging.warn(
./tflite-model-maker-0.4.3.tar.gz: tflite-model-maker-0.4.3/src/tensorflow_examples/lite/model_maker/third_party/efficientdet/keras/infer_lib.py: logging.warn('Use real representative dataset instead of fake ones.')
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/compat.py: tf.compat.v1.logging.warn(
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Export a separated vocab file even though '
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Export a separated label file even though '
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/task/custom_model.py: tf.compat.v1.logging.warn('Encountered unknown parameters: ' +
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/task/object_detector.py: tf.compat.v1.logging.warn(
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/core/task/object_detector.py: tf.compat.v1.logging.warn(
./tflite-model-maker-nightly-0.4.4.dev202402230613.tar.gz: tflite-model-maker-nightly-0.4.4.dev202402230613/src/tensorflow_examples/lite/model_maker/third_party/efficientdet/keras/infer_lib.py: logging.warn('Use real representative dataset instead of fake ones.')
./wyzeapy-0.5.23.tar.gz: wyzeapy-0.5.23/src/wyzeapy/services/wall_switch_service.py: logging.warn("%s", switch.single_press_type)
./xgboost-2.1.0.tar.gz: xgboost-2.1.0/cpp_src/dmlc-core/tracker/dmlc_tracker/tracker.py: logging.warn('gethostbyname(socket.getfqdn()) failed... trying on hostname()')
./xmodem-0.4.7.tar.gz: xmodem-0.4.7/PKG-INFO: * bugfix: remove DepreactionWarning for ``logging.warn()``, `PR #49
./xmodem-0.4.7.tar.gz: xmodem-0.4.7/xmodem.egg-info/PKG-INFO: * bugfix: remove DepreactionWarning for ``logging.warn()``, `PR #49
./tendo-0.3.0.tar.gz: tendo-0.3.0/demo/demo_colorer.py: logging.warn("a warning")
./tendo-0.3.0.tar.gz: tendo-0.3.0/src/tendo/colorer.py: ... logging.warn("yellow line")

Time: 0:00:29.720389
Found 136 matching lines in 53 projects

That's something like 0.6% of projects.

A few of these are also changelogs ("replace logging.warn with warnings.warn"), there's also the pylint and Ruff linters in there.

@vstinner
Copy link
Member Author

vstinner commented Aug 7, 2024

Please could you list these deprecations in one of those files? I guess we're not setting a version in which to remove? In which case, "Pending Removal in Future Versions"

Right, there is no planned removal. I mentioned the deprecated function in "Pending Removal in Future Versions".

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@gpshead gpshead added the needs backport to 3.13 bugs and security fixes label Aug 7, 2024
@vstinner vstinner merged commit d323997 into python:main Aug 9, 2024
34 checks passed
@vstinner vstinner deleted the revert_warn branch August 9, 2024 13:13
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2024
…22775)

This reverts commit dcc028d and
commit 6c54e5d.

Keep the deprecated logging warn() method in Python 3.13.

(cherry picked from commit d323997)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 9, 2024

GH-122856 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 9, 2024
@vstinner
Copy link
Member Author

vstinner commented Aug 9, 2024

Merged, thanks.

#122856 is a backport of this pull request to the 3.13 branch.

Please review also the 3.13 backport.

vstinner added a commit that referenced this pull request Aug 9, 2024
#122856)

gh-105376: Restore deprecated logging warn() method (GH-122775)

This reverts commit dcc028d and
commit 6c54e5d.

Keep the deprecated logging warn() method in Python 3.13.

(cherry picked from commit d323997)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
)

This reverts commit dcc028d and
commit 6c54e5d.

Keep the deprecated logging warn() method in Python 3.13.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants