Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax in generate_re_casefix.py #122699

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

JelleZijlstra
Copy link
Member

This was broken in gh-97963.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 5, 2024
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@JelleZijlstra JelleZijlstra merged commit b72c748 into python:main Aug 6, 2024
38 of 39 checks passed
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the casefix branch August 6, 2024 06:16
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2024

GH-122721 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2024

GH-122722 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Aug 6, 2024
JelleZijlstra added a commit that referenced this pull request Aug 6, 2024

This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull request Aug 6, 2024

This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants