bpo-36623: Clean parser headers and include files #12253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
clean_pgen
branch
2 times, most recently
from
32872e8
to
1b0478b
Compare
|
Sorry, I don't have bandwidth right now to review your PR. Maybe come back to me in 2 weeks. Your PR is scary because it's very long and it changes a lot of public headers at once. |
|
I think this should have a NEWS entry and What's New section, as it's removing headers that were publicly available (even if they should not have been). On the off chance that it breaks somebody, that will give them an issue to come and post on, or at least read the rationale. It can be the same issue as the original change. |
pablogsal
changed the title
|
It seems simple removal. LGTM if CI can compile them without any warnings. |
|
Resolved merge conflicts regarding the WhatsNew entry. |
methane
approved these changes
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these functions are not used/defined anymore.
https://bugs.python.org/issue36623