gh-119180: Improvements to ForwardRef.evaluate #122210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed some issues while writing documentation for this method.
28 tasks
JelleZijlstra
commented
Jul 24, 2024
| @@ -89,12 +89,10 @@ def evaluate(self, *, globals=None, locals=None, type_params=None, owner=None): | |||
| return value | |||
| if owner is None: | |||
| owner = self.__owner__ | |||
| if type_params is None and owner is None: | |||
There was a problem hiding this comment.
This check felt unnecessarily strict; many ForwardRefs can be evaluated correctly without worrying about type params.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Noticed some issues while writing documentation for this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some issues while writing documentation for this method.