Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121832: Skip subinterpreter static type check on iOS to restore test suite. #122150

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Jul 23, 2024

The CPython test suite will crash if you run any test that creates a subinterpreter after running the test_type_cache test.

This bug affects all platforms; but iOS is the only platform that reliably hits the bug as part of test suite execution, as it is the only platform that runs the test suite in a single process.

test_types is the only test that creates a subinterpreter after test_type_cache. This PR skips the subinterpreter slot tests that are part of test_types on iOS as a temporary measure so that we can observe other failures that might be occurring in iOS.

When a final fix for #121832 is in place, this test skip can be removed.

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e92cada 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freakboy3742 for unblocking this.

@markshannon markshannon merged commit 1bcc9eb into python:main Jul 23, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2024
…ore test suite. (pythonGH-122150)

(cherry picked from commit 1bcc9eb)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2024

GH-122159 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 23, 2024
@freakboy3742 freakboy3742 deleted the ios-test-skip branch July 23, 2024 22:26
freakboy3742 added a commit that referenced this pull request Jul 23, 2024
…tore test suite. (GH-122150) (#122159)

gh-121832: Skip subinterpreter static type check on iOS to restore test suite. (GH-122150)
(cherry picked from commit 1bcc9eb)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jul 27, 2024
freakboy3742 added a commit that referenced this pull request Jul 27, 2024
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jul 27, 2024
… (pythonGH-122340)

Revert test skip introduced by pythonGH-122150.
(cherry picked from commit 863a92f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit that referenced this pull request Jul 27, 2024
… (#122342)

Revert test skip introduced by GH-122150.
(cherry picked from commit 863a92f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants