gh-121605: Fix test hang when pyrepl is not available #121820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback repl does not support "exit" without parentheses, so the test would hang until the timeout expired.
colesbury
added
tests
|
!buildbot nogil refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 1158009 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
ambv
approved these changes
Jul 15, 2024
|
Thanks @colesbury for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2024
|
GH-121823 is a backport of this pull request to the 3.13 branch. |
ambv
pushed a commit
that referenced
this pull request
Jul 15, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…-121820) The fallback repl does not support "exit" without parentheses, so the test would hang until the timeout expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback repl does not support "exit" without parentheses, so the test would hang until the timeout expired if pyrepl is not available.
test_pyrepl.run_repltimeout is too small #121605