Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments #121074

Closed
wants to merge 1 commit into from
Closed

Fix typos in comments #121074

wants to merge 1 commit into from

Conversation

xyb
Copy link
Contributor

@xyb xyb commented Jun 27, 2024

No description provided.

@xyb
Copy link
Contributor Author

xyb commented Jul 2, 2024

@vstinner Would you please approve this pr? Thanks.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects/mimalloc/ directory is a copy of https://github.com/microsoft/mimalloc/ : please fix the typos upstream.

@bedevere-app
Copy link

bedevere-app bot commented Jul 2, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner vstinner closed this Jul 2, 2024
@vstinner
Copy link
Member

vstinner commented Jul 2, 2024

See also: #113141

@vstinner vstinner reopened this Jul 2, 2024
@vstinner vstinner closed this Jul 2, 2024
@xyb xyb deleted the fixtypos branch July 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants