gh-119357: Increase test coverage for keymap in _pyrepl #119358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenetriguba
commented
May 21, 2024
| @@ -30,7 +30,7 @@ | |||
| # types | |||
| Command = commands.Command | |||
| if False: | |||
| from .types import Callback, SimpleContextManager, KeySpec, CommandName | |||
There was a problem hiding this comment.
note: these two aren't used
|
I'd think this PR can skip news |
ambv
reviewed
May 21, 2024
|
@ambv beat me to it, thanks for the fix 🙂 I'll update the issue to more clearly encompass all of PyREPL instead of just the keymap module. Thanks for the feedback, let me know if you had any other requested changes! |
|
Thanks @eugenetriguba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @eugenetriguba and @ambv, I could not cleanly backport this to |
lysnikolaou
pushed a commit
to lysnikolaou/cpython
that referenced
this pull request
May 22, 2024
…ythonGH-119358) (cherry picked from commit 73ab83b) Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
GH-119414 is a backport of this pull request to the 3.13 branch. |
ambv
added a commit
that referenced
this pull request
May 22, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…#119358) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few test cases to the keymap module tests to increase the coverage.