Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118893: Evaluate all statements in the new REPL separately #119318

Merged
merged 3 commits into from
May 21, 2024
Merged

gh-118893: Evaluate all statements in the new REPL separately #119318

merged 3 commits into from
May 21, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 21, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 21, 2024
Closed
@pablogsal pablogsal requested a review from ambv May 21, 2024 16:06
@pablogsal pablogsal force-pushed the stmts-fix-2 branch 2 times, most recently from fcc44e6 to 40df02e Compare May 21, 2024 16:25
@ambv ambv added the topic-repl Related to the interactive shell label May 21, 2024
@ambv ambv added the skip news label May 21, 2024
@pablogsal pablogsal mentioned this pull request May 21, 2024
Merged
@ambv ambv enabled auto-merge (squash) May 21, 2024 19:12
lysnikolaou
lysnikolaou approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this!

@ambv ambv merged commit a3e4fec into python:main May 21, 2024
41 checks passed
@lysnikolaou lysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app
Copy link

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@pablogsal @ambv @miss-islington
pythongh-118893: Evaluate all statements in the new REPL separately (p…
76b149e 
…ythonGH-119318)

(cherry picked from commit a3e4fec)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119408 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
@miss-islington @pablogsal @ambv
[3.13] gh-118893: Evaluate all statements in the new REPL separately (G…
a463cd8 
…H-119318) (#119408)

(cherry picked from commit a3e4fec)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal @ambv @estyxx
pythongh-118893: Evaluate all statements in the new REPL separately (p…
83f9099 
…ython#119318)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@skirpichev skirpichev mentioned this pull request Jul 17, 2024
Merged
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees
No one assigned
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @lysnikolaou @ambv