gh-96471: Correct docs for queue shutdown raises #115838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpicWink
force-pushed
the
threading-queue-shutdown-no-raise-docs
branch
from
4fdeb68
to
63bdd42
Compare
EpicWink
force-pushed
the
threading-queue-shutdown-no-raise-docs
branch
from
63bdd42
to
c1bcb5d
Compare
gvanrossum
reviewed
Feb 23, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
gvanrossum
requested changes
Feb 23, 2024
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
gvanrossum
reviewed
Feb 25, 2024
gvanrossum
approved these changes
Feb 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue.join()andQueue.task_done()documentation (including doc-string)Queue.shutdown()behaviour (it doesn't raise itself, but causes other methods to raise)Queue.task_done()is called byQueue.shutdown(immediate=True)for each item in the queueCaused by: #104750
📚 Documentation preview 📚: https://cpython-previews--115838.org.readthedocs.build/