-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115543: Update py.exe to know about Python 3.13 and to install 3.12 by default #115544
Conversation
zooba
commented
Feb 15, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: py.exe launcher does not detect Windows Store 3.13 package #115543
…ll 3.12 by default
@@ -2052,7 +2054,8 @@ struct StoreSearchInfo { | |||
|
|||
|
|||
struct StoreSearchInfo STORE_SEARCH[] = { | |||
{ L"3", /* 3.11 */ L"9NRWMJP3717K" }, | |||
{ L"3", /* 3.12 */ L"9NCVDN91XZQP" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be part of the release manager's playbook when making a 3.x.0 release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bad idea, though it's in a bit of a weird spot really. The most likely way for people to get the update with the change is to install the new release, at which point they won't hit this code path (or in fact any Python 3 release, so even updating an old one).
It's possible to install the launcher separately with winget (or directly if you know the URL), which is what makes this feature at all useful, but those updates will lag anyway as we don't control them ourselves.
Plus it's all a bit of an experiment, so I kinda want to see how it goes before baking it into our formal process.
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ll 3.12 by default (pythonGH-115544) (cherry picked from commit 6cd18c7) Co-authored-by: Steve Dower <steve.dower@python.org>
GH-115689 is a backport of this pull request to the 3.12 branch. |
…ll 3.12 by default (pythonGH-115544) (cherry picked from commit 6cd18c7) Co-authored-by: Steve Dower <steve.dower@python.org>
GH-115690 is a backport of this pull request to the 3.11 branch. |
…ll 3.12 by default (pythonGH-115544)
…ll 3.12 by default (pythonGH-115544)