Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115543: Update py.exe to know about Python 3.13 and to install 3.12 by default #115544

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 15, 2024

@@ -2052,7 +2054,8 @@ struct StoreSearchInfo {


struct StoreSearchInfo STORE_SEARCH[] = {
{ L"3", /* 3.11 */ L"9NRWMJP3717K" },
{ L"3", /* 3.12 */ L"9NCVDN91XZQP" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of the release manager's playbook when making a 3.x.0 release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad idea, though it's in a bit of a weird spot really. The most likely way for people to get the update with the change is to install the new release, at which point they won't hit this code path (or in fact any Python 3 release, so even updating an old one).

It's possible to install the launcher separately with winget (or directly if you know the URL), which is what makes this feature at all useful, but those updates will lag anyway as we don't control them ourselves.

Plus it's all a bit of an experiment, so I kinda want to see how it goes before baking it into our formal process.

@zooba zooba merged commit 6cd18c7 into python:main Feb 19, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@zooba zooba deleted the gh-115543 branch February 19, 2024 20:36
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2024
…ll 3.12 by default (pythonGH-115544)

(cherry picked from commit 6cd18c7)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Feb 19, 2024

GH-115689 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2024
…ll 3.12 by default (pythonGH-115544)

(cherry picked from commit 6cd18c7)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Feb 19, 2024

GH-115690 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 19, 2024
zooba added a commit that referenced this pull request Feb 19, 2024
…2 by default (GH-115544)

(cherry picked from commit 6cd18c7)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Feb 19, 2024
…2 by default (GH-115544)

(cherry picked from commit 6cd18c7)

Co-authored-by: Steve Dower <steve.dower@python.org>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants