Correct description of inheriting from another class #114660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"inherits <someclass>" grates to this reader. I think it should be "inherits from <someclass>".
bedevere-app
bot
added
awaiting review
docs
terryjreedy
added
needs backport to 3.11
|
Other instances in Doc/library There are 32 other instances of 'inherits', nearly all with 'inherits from'. I agree that the latter is more correct. I am asking about this on the coredev discord. |
JelleZijlstra
approved these changes
Feb 1, 2024
|
I just amended the PR with the changes I found, which are (I believe) the same ones Terry identified. |
|
Thanks @smontanaro for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 1, 2024
"inherits <someclass>" grates to this reader. I think it should be "inherits from <someclass>". (cherry picked from commit c9c6e04) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
|
GH-114868 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 1, 2024
"inherits <someclass>" grates to this reader. I think it should be "inherits from <someclass>". (cherry picked from commit c9c6e04) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
|
GH-114869 is a backport of this pull request to the 3.11 branch. |
|
Thanks Skip! |
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 1, 2024
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 1, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
"inherits <someclass>" grates to this reader. I think it should be "inherits from <someclass>".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"inherits " grates this reader. I think it should be "inherits from ".
📚 Documentation preview 📚: https://cpython-previews--114660.org.readthedocs.build/