Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-67230: document new csv quoting modes in whatsnew (gh-103491) #103491

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

smontanaro
Copy link
Contributor

@smontanaro smontanaro commented Apr 12, 2023

Add blurb about recent change to csv.

Add blurb about changes to :mod:`csv`.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 12, 2023
@merwok merwok changed the title Update 3.12.rst bpo-67230: document new csv quoting modes in whatsnew Apr 12, 2023
@merwok merwok changed the title bpo-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew Apr 12, 2023
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@merwok merwok self-assigned this Apr 12, 2023
@smontanaro
Copy link
Contributor Author

This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So...

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@merwok
Copy link
Member

merwok commented Apr 13, 2023

I see a change was requested by merwok but can't see what it is. So...

Ah! «requested changes» is a review status (others are «approved» and «commented»)
Comments can be standalone or part of a review; I used the latter mode, made a few comments (some being change suggestions) and published my review with the «changes requested» status. Then I applied some of my suggested changes directly. So you saw «changes requested», some hidden comments («resolved» by the application of the suggestion), and one comment about the wording.

@merwok merwok changed the title gh-67230: document new csv quoting modes in whatsnew gh-67230: document new csv quoting modes in whatsnew (gh-103491) Apr 13, 2023
@merwok merwok merged commit fb38c1b into python:main Apr 13, 2023
@samwyse
Copy link
Contributor

samwyse commented Apr 13, 2023

@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢

@smontanaro
Copy link
Contributor Author

smontanaro commented Apr 13, 2023 via email

aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@chaeynz
Copy link

chaeynz commented Oct 6, 2023

@smontanaro were you responsible for the csv.QUOTE_NULL?

You're an absolute legend!
I am working a project where I need exactly this, thank you so much! :)

@smontanaro
Copy link
Contributor Author

Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants