Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen should ideally not need to know the optimization level #123958

Closed
iritkatriel opened this issue Sep 11, 2024 · 6 comments
Closed

codegen should ideally not need to know the optimization level #123958

iritkatriel opened this issue Sep 11, 2024 · 6 comments
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

Optimization level is used for things that can be done in ast_opt. I'll try to move them there.

Linked PRs
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Sep 11, 2024
@iritkatriel iritkatriel self-assigned this Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 11, 2024
Merged
iritkatriel added a commit that referenced this issue Sep 11, 2024
@iritkatriel
gh-123958: apply docstring removal optimization in ast_opt instead of…
e07154f 
… codegen (#123959)
@hugovk
Copy link
Member

hugovk commented Sep 15, 2024

PR merged, closing issue.

@hugovk hugovk closed this as completed Sep 15, 2024
@iritkatriel iritkatriel reopened this Sep 15, 2024
@iritkatriel
Copy link
Member Author

There's another usage still to remove.

@hugovk
Copy link
Member

hugovk commented Sep 15, 2024

Thanks, sorry I was too quick with the close button :)

@Eclips4
Copy link
Member

Eclips4 commented Sep 15, 2024

So, the only remaining occurrence of OPTIMIZATION_LEVEL is related to the assert statement.
@iritkatriel, are you currently working on this? If not, can I attempt to fix it?

@iritkatriel
Copy link
Member Author

I have a patch for it. Thanks.

iritkatriel added a commit to iritkatriel/cpython that referenced this issue Sep 16, 2024
@iritkatriel
pythongh-123958: move assert optimization from codegen to ast_opt
8243017
@bedevere-app bedevere-app bot mentioned this issue Sep 16, 2024
Closed
@iritkatriel
Copy link
Member Author

I got as far as I could with this, the assert optimization needs to stay in ast_opt (see discussion on PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iritkatriel @hugovk @Eclips4