Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock.patch introspects original even when new_callable set #119600

Closed
rbtcollins opened this issue May 27, 2024 · 0 comments
Closed

mock.patch introspects original even when new_callable set #119600

rbtcollins opened this issue May 27, 2024 · 0 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@rbtcollins
Copy link
Member

rbtcollins commented May 27, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

In order to patch flask.g e.g. as in #84982, that proxies getattr must not be invoked. For that, mock must not try to read from the original object. In some cases that is unavoidable, e.g. when doing autospec. However, patch("flask.g", new_callable=MagicMock) should be entirely safe.

CPython versions tested on:

3.11, 3.12

Operating systems tested on:

Linux, macOS, Windows, Other

Linked PRs
@rbtcollins rbtcollins added the type-bug An unexpected behavior, bug, or error label May 27, 2024
rbtcollins added a commit to rbtcollins/cpython that referenced this issue May 27, 2024
@rbtcollins
Issue python#119600: mock: do not access attributes of original when …
4e69397 
…new_callable is set

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
@Eclips4 Eclips4 added the stdlib Python modules in the Lib dir label May 27, 2024
rbtcollins added a commit to rbtcollins/cpython that referenced this issue May 27, 2024
@rbtcollins
Issue python#119600: mock: do not access attributes of original when …
224f2b5 
…new_callable is set

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
@bedevere-app bedevere-app bot mentioned this issue Jun 10, 2024
Merged
rbtcollins added a commit to rbtcollins/cpython that referenced this issue Jun 10, 2024
@rbtcollins
Issue python#119600: mock: do not access attributes of original when …
d940c98 
…new_callable is set

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
cjw296 pushed a commit that referenced this issue Jun 11, 2024
@rbtcollins
gh-119600: mock: do not access attributes of original when new_callab…
422c4fc 
…le is set (#119601)

In order to patch flask.g e.g. as in #84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 11, 2024
@rbtcollins @miss-islington
pythongh-119600: mock: do not access attributes of original when new_…
3e8acc1 
…callable is set (pythonGH-119601)

In order to patch flask.g e.g. as in pythonGH-84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
(cherry picked from commit 422c4fc)

Co-authored-by: Robert Collins <robert.collins@cognite.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 11, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 11, 2024
@rbtcollins @miss-islington
pythongh-119600: mock: do not access attributes of original when new_…
cc8cd2f 
…callable is set (pythonGH-119601)

In order to patch flask.g e.g. as in pythonGH-84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
(cherry picked from commit 422c4fc)

Co-authored-by: Robert Collins <robert.collins@cognite.com>
@bedevere-app bedevere-app bot mentioned this issue Jun 11, 2024
Merged
cjw296 pushed a commit that referenced this issue Jun 11, 2024
@miss-islington @rbtcollins
[3.12] gh-119600: mock: do not access attributes of original when new…
fa291a3 
…_callable is set (GH-119601) (#120335)

gh-119600: mock: do not access attributes of original when new_callable is set (GH-119601)

In order to patch flask.g e.g. as in GH-84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
(cherry picked from commit 422c4fc)

Co-authored-by: Robert Collins <robert.collins@cognite.com>
cjw296 pushed a commit that referenced this issue Jun 11, 2024
@miss-islington @rbtcollins
[3.13] gh-119600: mock: do not access attributes of original when new…
aba5f2a 
…_callable is set (GH-119601) (#120334)

gh-119600: mock: do not access attributes of original when new_callable is set (GH-119601)

In order to patch flask.g e.g. as in GH-84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
(cherry picked from commit 422c4fc)

Co-authored-by: Robert Collins <robert.collins@cognite.com>
@hugovk hugovk closed this as completed Jun 15, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@rbtcollins @mrahtz
pythongh-119600: mock: do not access attributes of original when new_…
18a58be 
…callable is set (python#119601)

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@rbtcollins @noahbkim
pythongh-119600: mock: do not access attributes of original when new_…
c3b69b3 
…callable is set (python#119601)

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@rbtcollins @estyxx
pythongh-119600: mock: do not access attributes of original when new_…
6936ec7 
…callable is set (python#119601)

In order to patch flask.g e.g. as in python#84982, that
proxies getattr must not be invoked. For that,
mock must not try to read from the original
object. In some cases that is unavoidable, e.g.
when doing autospec. However, patch("flask.g",
new_callable=MagicMock) should be entirely safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rbtcollins @hugovk @Eclips4