Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pystats counter for invalidated executors #115168

Closed
mdboom opened this issue Feb 8, 2024 · 3 comments
Closed

Add pystats counter for invalidated executors #115168

mdboom opened this issue Feb 8, 2024 · 3 comments
Labels
type-feature A feature request or enhancement

Comments

@mdboom
Copy link
Contributor

mdboom commented Feb 8, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

As discussed in an investigation into why some pystats are surprising, I suggested that it would be useful to have counts for when executors are invalidated (for example, when the globals or builtins dictionary changes).

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@mdboom mdboom added the type-feature A feature request or enhancement label Feb 8, 2024
mdboom added a commit to mdboom/cpython that referenced this issue Feb 8, 2024
@mdboom
pythongh-115168: Add pystats counter for invalidated executors
730ffec
@bedevere-app bedevere-app bot mentioned this issue Feb 8, 2024
Merged
mdboom added a commit to mdboom/cpython that referenced this issue Feb 12, 2024
@mdboom
pythongh-115168: Add pystats counter for invalidated executors
4c37278
Fidget-Spinner pushed a commit that referenced this issue Feb 26, 2024
@mdboom
gh-115168: Add pystats counter for invalidated executors (GH-115169)
b05afdd
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@mdboom @woodruffw
pythongh-115168: Add pystats counter for invalidated executors (pytho…
f534d7f 
…nGH-115169)
@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

The PR has been merged, OK to close or is there more to do?

adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@mdboom @adorilson
pythongh-115168: Add pystats counter for invalidated executors (pytho…
44068e9 
…nGH-115169)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@mdboom @diegorusso
pythongh-115168: Add pystats counter for invalidated executors (pytho…
fc56881 
…nGH-115169)
@hugovk
Copy link
Member

hugovk commented Jun 15, 2024

Triage: the linked PR is merged, can this be closed?

@mdboom
Copy link
Contributor Author

mdboom commented Jun 17, 2024

Yes.

@mdboom mdboom closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @hugovk