Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jit.c always recompiles, even on non-JIT builds #114883

Closed
brandtbucher opened this issue Feb 1, 2024 · 1 comment
Closed

jit.c always recompiles, even on non-JIT builds #114883

brandtbucher opened this issue Feb 1, 2024 · 1 comment
Assignees
@brandtbucher
Labels
3.13 bugs and security fixes build The build process and cross-build topic-JIT

Comments

@brandtbucher
Copy link
Member

brandtbucher commented Feb 1, 2024 •
edited by bedevere-app bot
Loading

I think I messed up the Makefile rules for Python/jit.o and regen-jit. Since regen-jit is "phony", the rule isn't in the dependency graph and make has no way of knowing if a recompile is necessary.

We may have to do something similar to what we did for the Windows builds and encode the dependencies in the Makefile. Or maybe there's an easier way. If anyone has any tips, please share!

Linked PRs
@brandtbucher brandtbucher added build The build process and cross-build 3.13 bugs and security fixes labels Feb 1, 2024
@brandtbucher brandtbucher self-assigned this Feb 1, 2024
@brandtbucher brandtbucher changed the title jit.c *always* recompiles, even on non-JIT builds jit.c always recompiles, even on non-JIT builds Feb 1, 2024
@zware
Copy link
Member

zware commented Feb 1, 2024

I don't have a full understanding of how the JIT build works, but I think I'm on the cusp of a Makefile fix that you can tweak to work correctly for the JIT-enabled build. PR to come.

zware added a commit to zware/cpython that referenced this issue Feb 1, 2024
@zware
pythongh-114883: Fix Makefile dependency tree for non-jit builds
47a6c73
@bedevere-app bedevere-app bot mentioned this issue Feb 1, 2024
Merged
zware added a commit to zware/cpython that referenced this issue Feb 3, 2024
@zware
pythongh-114883: Fix Makefile dependency tree for non-jit builds
59824a1
zware added a commit that referenced this issue Feb 3, 2024
@zware
gh-114883: Fix Makefile dependency tree for non-jit builds (GH-114884)
1032326
@zware zware closed this as completed Feb 3, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@zware @aisk
pythongh-114883: Fix Makefile dependency tree for non-jit builds (pyt…
0113278 
…honGH-114884)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@zware @fsc-eriker
pythongh-114883: Fix Makefile dependency tree for non-jit builds (pyt…
e2cd817 
…honGH-114884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandtbucher brandtbucher

Labels
3.13 bugs and security fixes build The build process and cross-build topic-JIT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zware @brandtbucher